Conversation
There was a problem hiding this comment.
Pull request overview
Updates elapid to target NumPy 2.x and adjusts code/tests and packaging workflow to match, addressing the project’s dependency upgrade request.
Changes:
- Bump project version and update dependency constraints to require NumPy >= 2.0 (and add SciPy minimum).
- Update
AxisErrorusage/imports for NumPy 2 in library code and tests. - Adjust PyPI publish workflow (Python version + permissions/auth inputs).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pyproject.toml |
Updates package version and dependency constraints for NumPy 2 (and SciPy). |
elapid/models.py |
Switches AxisError to NumPy 2 import path and updates raising behavior/doc text. |
tests/test_models.py |
Aligns tests with NumPy 2 AxisError import/expectations and minor formatting. |
.github/workflows/publish-pypi.yml |
Updates publish job Python version and job permissions/auth configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pyproject.toml
Outdated
| python = ">=3.9" | ||
| numpy = ">=1.18,<2.0" | ||
| numpy = ">=2.0" | ||
| pandas = ">=1.0.3" |
There was a problem hiding this comment.
python = ">=3.9" is now potentially inconsistent with numpy = ">=2.0" and the release workflow building with Python 3.11. To avoid users attempting installs on unsupported Python versions (and dependency resolution failures), align the declared Python constraint with the actual supported/tested versions (and update CI matrices accordingly if needed).
| permissions: | ||
| id-token: write |
There was a problem hiding this comment.
The workflow grants id-token: write but still authenticates via PYPI_API_TOKEN. If you’re not using PyPI Trusted Publishing, drop the id-token permission to follow least privilege; if you are, switch the publish step to OIDC/trusted publishing and remove the API token secret usage.
| permissions: | |
| id-token: write |
Closes #109